-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-1028) puppetlabs/stdlib: Allow 9.x #1113
(CONT-1028) puppetlabs/stdlib: Allow 9.x #1113
Conversation
|
6845dab
to
7645e20
Compare
6a481a7
to
c0b8640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this contribution!
@LukasAud thanks for the quick merge! Is it possible to get a new release soon? |
@@ -10,7 +10,7 @@ | |||
"dependencies": [ | |||
{ | |||
"name": "puppetlabs/stdlib", | |||
"version_requirement": ">= 4.16.0 < 9.0.0" | |||
"version_requirement": ">= 4.16.0 < 10.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, stdlib::ensure_packages
appeared in 9.0.0
(where merge
is also available as stdlib::merge
). Not sure if we should bump the minimum version to 9.0.0 or rather use the deprecated functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to do it now and rip out all the legacy function calls. Otherwise we need to touch the codebase in the future again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK! I opened #1114 to update the minimum version requirement.
@bastelfreak We are working on releases. However, due to some recent maintenance, there is a lengthy task that we need to address before we can cut a release for each module. We will try to release as soon as possible. |
this is a resubmission of #1111