Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CDPE-6220) Fix variable references in run.pp #977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(CDPE-6220) Fix variable references in run.pp #977

wants to merge 1 commit into from

Commits on Apr 18, 2024

  1. (CDPE-6220) Fix variable references in run.pp 

    Currently, CD4PE is using this module as part of the version 5
installation. When we use docker::run, we're getting warnings like this
in the customer-facing terminal output:

Unknown variable: 'docker::docker_group'. (file: /Users/eric.putnam/ws/cd4pe/PipelinesInfra/deploy/envs/cdpe6633/.modules/docker/manifests/run.pp, line: 268, column: 19)
Unknown variable: 'docker::service_name'. (file: /Users/eric.putnam/ws/cd4pe/PipelinesInfra/deploy/envs/cdpe6633/.modules/docker/manifests/run.pp, line: 267, column: 19)

This doesn't make for a very good customer experience. Since these vars
are in docker::params, I added "::params" to the two lines where
docker_group and service_name are assigned and that seemed to take care
of the warnings. Please correct me if I'm wrong about this change, our
main goal is to get rid of these warnings.
    @eputnam
    eputnam committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f811aa7 View commit details
    Browse the repository at this point in the history