Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --reject-with tcp-reset for TCP rules #1184

Open
chrisongthb opened this issue Jan 5, 2024 · 0 comments · May be fixed by #1194
Open

Allow --reject-with tcp-reset for TCP rules #1184

chrisongthb opened this issue Jan 5, 2024 · 0 comments · May be fixed by #1194

Comments

@chrisongthb
Copy link

Describe the Bug

When defining a TCP rule, one may want to use --reject-with tcp-reset. This is not possible in the current Version of this module v7.0.2.

Expected Behavior

The module should per-se accept 'tcp-reset' next to 'icmp(6)-net-unreachable', 'icmp(6)-host-unreachable', 'adm-prohibited' and the others. Further more the module should contain a parameter validation: 'tcp-reset' makes only sense, if proto is set to 'tcp'. If that does not match, a helpful error message should be printed on the agent side.

Steps to Reproduce

firewall { '998 reject forward tcp traffic with reset':
  chain  => 'FORWARD',
  proto  => 'tcp',
  jump   => 'reject',
  reject => 'tcp-reset',
}

Environment

  • Module version v7.0.2
  • Puppet Agent version 7.26.0
  • Puppet Server version 7.13.0
  • Platform Ubuntu 20.04, 22.04
chrisongthb added a commit to chrisongthb/chrisongthb-puppetlabs-firewall that referenced this issue Jan 5, 2024
gcoxmoz added a commit to gcoxmoz/puppetlabs-firewall that referenced this issue Mar 8, 2024
@gcoxmoz gcoxmoz linked a pull request Mar 8, 2024 that will close this issue
3 tasks
gcoxmoz added a commit to gcoxmoz/puppetlabs-firewall that referenced this issue Mar 18, 2024
gcoxmoz added a commit to gcoxmoz/puppetlabs-firewall that referenced this issue Mar 27, 2024
gcoxmoz added a commit to gcoxmoz/puppetlabs-firewall that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants