Ensure global variables are unique among providers #1227
+81
−81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some global variable names were re-used between the firewall and firewallchain providers. This causes intermittent catalog application failures.
The proposed fix is to prefix all
firewall
global variables withfw_
and allfirewallchain
global variables withfwc_
.Additional Context
For example, if the
firewallchain
provider code is loaded after thefirewall
provider code, the$list_command
global variable value loses theiptables
andipt6ables
keys and values. E.g.puppetlabs-firewall/lib/puppet/provider/firewall/firewall.rb
Lines 11 to 16 in 810e7fa
becomes
puppetlabs-firewall/lib/puppet/provider/firewallchain/firewallchain.rb
Lines 10 to 13 in 810e7fa
Then when the
firewall
provider tries to process a rule that has theiptables
protocol, the provider is unable to lookup the current rules because$list_command['iptables']
is no longer defined.Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply
)