Ensure global variables are unique among providers

[nabertrand]

Summary

Some global variable names were re-used between the firewall and firewallchain providers. This causes intermittent catalog application failures.

The proposed fix is to prefix all firewall global variables with fw_ and all firewallchain global variables with fwc_.

Additional Context

For example, if the firewallchain provider code is loaded after the firewall provider code, the $list_command global variable value loses the iptables and ipt6ables keys and values. E.g.

puppetlabs-firewall/lib/puppet/provider/firewall/firewall.rb

Lines 11 to 16 in 810e7fa

	$list_command = {
	'IPv4' => 'iptables-save',
	'iptables' => 'iptables-save',
	'IPv6' => 'ip6tables-save',
	'ip6tables' => 'ip6tables-save'
	}

becomes

puppetlabs-firewall/lib/puppet/provider/firewallchain/firewallchain.rb

Lines 10 to 13 in 810e7fa

	$list_command = {
	'IPv4' => 'iptables-save',
	'IPv6' => 'ip6tables-save'
	}

Then when the firewall provider tries to process a rule that has the iptables protocol, the provider is unable to lookup the current rules because $list_command['iptables'] is no longer defined.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)