WIP: Add safe-updates for client #1084
Conversation
|
Adding possibility to set it via option. |
|
How is that possible? https://travis-ci.org/puppetlabs/puppetlabs-mysql/jobs/383056902 - not failing I did not modify {{spec/functions/mysql_deepmerge_spec.rb}}. It seems to be not modified for last 4 months Issue with failing syntax check was visible even in other merged commits: https://travis-ci.org/puppetlabs/puppetlabs-mysql/builds/383387368 in PR: #1044 |
Due to RuboCop settings, usage of %w[] was not working correctly. That change fixes that. Related to #1084
That change introduces option safe-updates for mysql clients by setting it in ~/.my.cnf
|
Rebase done with commit from branch |
|
@pasuder Your PR is currently failing acceptance tests. In addition it needs to be rebased. |
|
Ah, rebase should I do, I will. |
|
@pasuder Your pr is currently failing against both acceptance and unit test's. The acceptance test's seem to failing on the mysql::server::backup test and getting an error back while the unit test seems to be expecting a string, "1", but are instead getting an integer, 1. |
|
I will be not able to test it. Let's close it. |
That change introduces option safe-updates for mysql clients by setting it in
~/.my.cnf.