-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{WIP} remove exporter class state from infra nodes #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, just needs to be prettier i.e.
- If you want a blank line, just use one. Currently there is sometimes one sometimes two
- Indentation should be correct i.e.
- +2 spaces of indent on following line for every opening brace (, { or [
- -2 spaces of indent for every closing brace
- Comments should also follow indentation rules
@dylanratcliffe like this? |
@MartyEwings Almost, lines 26 though 35 inclusive should be indented 2 more spaces |
Thanks @dylanratcliffe fixed it... why is the styling the most difficult part for me± |
Much more better. Do you have puppet-lint working in vscode? That helps a lot |
Resolves #24
Class fails to detect if RSAN postgres user has been removed already, would like to do this for idempotency sake, however the procedure for removal will be to run puppet once with this class and uninstall the module