Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mocha deprecation warnings #39

Merged
merged 3 commits into from
Jan 13, 2021
Merged

remove mocha deprecation warnings #39

merged 3 commits into from
Jan 13, 2021

Conversation

MartyEwings
Copy link
Collaborator

removes

Deprecation Warnings:

puppetlabs_spec_helper: defaults mock_with to :mocha. See https://github.com/puppetlabs/puppetlabs_spec_helper#mock_with to choose a sensible value for you

@MartyEwings MartyEwings added the enhancement New feature or request label Jan 13, 2021
@MartyEwings MartyEwings requested a review from timidri January 13, 2021 13:18
Copy link
Collaborator

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MartyEwings, can you rebase this PR on the HEAD of main?

Copy link
Collaborator

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've resolved the conflict, this can be merged.

@MartyEwings MartyEwings merged commit 65a8669 into main Jan 13, 2021
@MartyEwings MartyEwings deleted the sync_update branch May 7, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants