-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation and release prep #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I put in a few nit picks. You may also want to generate the REFERENCE.md. The code headers may need to be updated to account for it.
pdk bundle exec rake strings:generate:reference
The REFERENCE.md will populate the reference page in the forge and generate docs around the code from the header comments with `puppet-strings.
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
We should document resource requirements so the customer knows what size of a machine needs to be deployed for RSAN. |
Also, the agent OS needs to be the same OS as the master or it cannot deploy the client tools automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting updates
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
iv been testing on m1 medium, and that's probably as small as you want any Puppet agent, ill set that as minimum |
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
Co-authored-by: Jarret Lavallee <jarretlavallee@users.noreply.github.com>
…nto Documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ship it
resolves #6