(MODULES-7009) Do not run HTTPS tests on old OSes

puppetlabs · Jul 31, 2018 · 424acbe · 424acbe
1 parent a766296
commit 424acbe
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 10 deletions.
diff --git a/README.markdown b/README.markdown
@@ -850,24 +850,25 @@ Specifies the user to run as for repository operations. (Requires the `user` fea
 
 ## Limitations
 
-Git is the only VCS provider officially [supported by Puppet Inc.](https://forge.puppet.com/supported)
+Git is the only VCS provider officially [supported by Puppet Inc.](https://forge.puppet.com/supported) Git with 3.18 changes the maximum enabled TLS protocol version, this breaks some HTTPS functionality on older OSes. They are Enterprise Linux 5 OSes and OracleLinux 6
 
 The includes parameter is only supported when SVN client version is >= 1.6.
 
-This module has been tested with Puppet 2.7 and higher.
+This module has been tested with Puppet 4.7 and higher.
 
 The module has been tested on:
 
 * CentOS 5/6/7
-* Debian 6/7/8
+* Debian 8/9
 * Oracle 5/6/7
 * Red Hat Enterprise Linux 5/6/7
-* Scientific Linux 5/6/7
-* SLES 10/11/12
-* Ubuntu 10.04/12.04/14.04/16.04
+* Scientific Linux 6/7
+* SLES 11/12
+* Ubuntu 14.04/16.04/18.04
 
 Testing on other platforms has been light and cannot be guaranteed.
 
+
 ## Development
 
 Puppet Inc. modules on the Puppet Forge are open projects, and community contributions are essential for keeping them great. We can't access the huge number of platforms and myriad of hardware, software, and deployment configurations that Puppet is intended to serve.

diff --git a/spec/acceptance/clone_repo_spec.rb b/spec/acceptance/clone_repo_spec.rb
@@ -37,7 +37,7 @@
     end
   end
 
-  context 'with using a https source on github' do
+  context 'with using a https source on github', unless: only_supports_weak_encryption do
     pp = <<-MANIFEST
       vcsrepo { "#{tmpdir}/httpstestrepo":
         ensure => present,

diff --git a/spec/acceptance/modules_1596_spec.rb b/spec/acceptance/modules_1596_spec.rb
@@ -2,7 +2,7 @@
 
 tmpdir = default.tmpdir('vcsrepo')
 
-describe 'clones a remote repo' do
+describe 'clones a remote repo', unless: only_supports_weak_encryption do
   before(:all) do
     File.expand_path(File.join(File.dirname(__FILE__), '..'))
     shell("mkdir -p #{tmpdir}") # win test

diff --git a/spec/acceptance/modules_1800_spec.rb b/spec/acceptance/modules_1800_spec.rb
@@ -2,7 +2,7 @@
 
 tmpdir = default.tmpdir('vcsrepo')
 
-describe 'clones a remote repo' do
+describe 'clones a remote repo', unless: only_supports_weak_encryption do
   before(:all) do
     File.expand_path(File.join(File.dirname(__FILE__), '..'))
     shell("mkdir -p #{tmpdir}") # win test

diff --git a/spec/acceptance/modules_753_spec.rb b/spec/acceptance/modules_753_spec.rb
@@ -2,7 +2,7 @@
 
 tmpdir = default.tmpdir('vcsrepo')
 
-describe 'clones a remote repo' do
+describe 'clones a remote repo', unless: only_supports_weak_encryption do
   before(:all) do
     File.expand_path(File.join(File.dirname(__FILE__), '..'))
     shell("mkdir -p #{tmpdir}") # win test

diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb
@@ -49,3 +49,10 @@
     end
   end
 end
+
+# git with 3.18 changes the maximum enabled TLS protocol version, older OSes will fail these tests
+def only_supports_weak_encryption
+  return_val = (fact('osfamily') == 'RedHat' && fact('operatingsystemmajrelease') == '5') ||
+    (fact('operatingsystem') == 'OracleLinux' && fact('operatingsystemmajrelease') == '6')
+  return_val
+end