(RE-15565) Make auth config customizable and remove default dummy auth #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only includes the auth key in the base config if it's specified in the values file, which allows the auth config to now be specified in a separate config file (i.e. using a service account to bind where you don't want the credentials written in a ConfigMap).
This also removes using the dummy auth provider (Only used for unit testing and local development) by default, which I consider backwards compatible, since vmpooler will not allow startup anyways if the dummy auth provider is used unless
VMPOOLER_DEBUGis true, which is not the case in the api and manager deployment resources.