Merge pull request #3 from puppetlabs/fix-tests

fix simplecov with jruby, add a .rubocop.yml config file
puppetlabs · Dec 10, 2021 · f6ec318 · f6ec318
2 parents 356dfb3 + 5565438
commit f6ec318
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 5 deletions.
diff --git a/.jrubyrc b/.jrubyrc
@@ -0,0 +1,2 @@
+# for simplecov to work in jruby, without this we are getting errors when debugging spec tests
+debug.fullTrace=true
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -0,0 +1,51 @@
+AllCops:
+  Include:
+    - 'lib/**/*.rb'
+  Exclude:
+    - 'scripts/**/*'
+    - 'spec/**/*'
+    - 'vendor/**/*'
+    - Gemfile
+    - Rakefile
+
+# These short variable names make sense as exceptions to the rule, but generally I think short variable names do hurt readability
+Naming/MethodParameterName:
+  AllowedNames:
+    - vm
+    - dc
+    - s
+    - x
+    - f
+
+#new cops:
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: false
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+Style/SwapValues: # (new in 1.1)
+  Enabled: false
+
+#disabled
+
+Metrics/AbcSize:
+  Max: 77
+Metrics/ClassLength:
+  Max: 430
+Metrics/CyclomaticComplexity:
+  Max: 14
+Metrics/MethodLength:
+  Max: 48
+Metrics/PerceivedComplexity:
+  Max: 14
+Metrics/ParameterLists:
+  Max: 6
+Layout/LineLength:
+  Max: 220
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-# require 'simplecov'
-# SimpleCov.start do
-#   add_filter '/spec/'
-# end
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/spec/'
+end
 require 'helpers'
 require 'rspec'
 require 'vmpooler'

diff --git a/vmpooler-provider-gce.gemspec b/vmpooler-provider-gce.gemspec
@@ -27,7 +27,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rack-test', '>= 0.6'
   s.add_development_dependency 'rspec', '>= 3.2'
   s.add_development_dependency 'rubocop', '~> 1.1.0'
-  #s.add_development_dependency 'simplecov', '>= 0.11.2'
+  s.add_development_dependency 'simplecov', '>= 0.11.2'
   s.add_development_dependency 'thor', '~> 1.0', '>= 1.0.1'
   s.add_development_dependency 'yarjuf', '>= 2.0'
 end
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# for simplecov to work in jruby, without this we are getting errors when debugging spec tests
		debug.fullTrace=true