Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RE-15124) Decouple DNS Record Management into DNS Plugins #21

Merged
merged 9 commits into from
Apr 18, 2023
Merged

(RE-15124) Decouple DNS Record Management into DNS Plugins #21

merged 9 commits into from
Apr 18, 2023

Conversation

yachub
Copy link

@yachub yachub commented Feb 7, 2023 •
edited
Loading

This will decouple DNS record management by extracting the functionality into DNS plugins, similar to compute providers.

  • Implements a new parent method get_vm_ip_address used to store the ip address in redis via vmpooler pool manager.
  • The domain is obtained via the pool's dns configuration as opposed to the removed "global" dns config option.

Depends on puppetlabs/vmpooler#551

@yachub yachub added the enhancement New feature or request label Feb 7, 2023
@yachub yachub mentioned this pull request Feb 7, 2023
Merged
@yachub yachub changed the title Decouple DNS Record Management into DNS Plugins (RE-15124) Decouple DNS Record Management into DNS Plugins Feb 7, 2023
@yachub yachub mentioned this pull request Feb 15, 2023
Merged
@yachub yachub force-pushed the vmpooler-dns-gcp branch 2 times, most recently from 09ce9d6 to 1f54e37 Compare February 15, 2023 20:45
@yachub yachub changed the title (RE-15124) Decouple DNS Record Management into DNS Plugins [WIP] (RE-15124) Decouple DNS Record Management into DNS Plugins Feb 28, 2023
@yachub yachub force-pushed the vmpooler-dns-gcp branch from 18a7024 to 3d5a688 Compare March 7, 2023 17:26
genebean
genebean suggested changes Mar 22, 2023
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/vmpooler/providers/gce.rb Outdated Show resolved Hide resolved
lib/vmpooler/providers/gce.rb Show resolved Hide resolved
spec/unit/providers/gce_spec.rb Outdated Show resolved Hide resolved
vmpooler-provider-gce.gemspec Outdated Show resolved Hide resolved
@yachub yachub force-pushed the vmpooler-dns-gcp branch from 0cd41cd to 7c006f8 Compare March 28, 2023 21:44
@yachub yachub added backwards-incompatible This issue or pull request includes breaking changes and removed enhancement New feature or request labels Mar 29, 2023
@yachub yachub force-pushed the vmpooler-dns-gcp branch from 7c006f8 to 06d940a Compare March 29, 2023 13:54
@yachub yachub marked this pull request as ready for review March 29, 2023 13:55
@yachub yachub requested a review from a team as a code owner March 29, 2023 13:55
@yachub yachub changed the title [WIP] (RE-15124) Decouple DNS Record Management into DNS Plugins (RE-15124) Decouple DNS Record Management into DNS Plugins Mar 29, 2023
e-gris
e-gris approved these changes Mar 31, 2023
View reviewed changes
Copy link

@e-gris e-gris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of truly trivial comments.

install-gemfile-lock Show resolved Hide resolved
lib/vmpooler/providers/gce.rb Show resolved Hide resolved
@yachub yachub changed the title (RE-15124) Decouple DNS Record Management into DNS Plugins [WIP] (RE-15124) Decouple DNS Record Management into DNS Plugins Apr 17, 2023
@yachub yachub force-pushed the vmpooler-dns-gcp branch from 6e5d88e to aa805e5 Compare April 17, 2023 14:23
@yachub yachub force-pushed the vmpooler-dns-gcp branch from aa805e5 to 355d3a6 Compare April 17, 2023 14:27
@yachub yachub changed the title [WIP] (RE-15124) Decouple DNS Record Management into DNS Plugins (RE-15124) Decouple DNS Record Management into DNS Plugins Apr 17, 2023
@yachub yachub merged commit bee6655 into main Apr 18, 2023
@yachub yachub deleted the vmpooler-dns-gcp branch April 18, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-gris e-gris e-gris approved these changes

@genebean genebean genebean approved these changes

Assignees
No one assigned
Labels
backwards-incompatible This issue or pull request includes breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yachub @genebean @e-gris