Adding the cloud DNS API library and related methods #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we setup DNS when a VM is created and tear it down when a VM is deleted the DNS zone should exist already and is referenced by a provider setting the dns zone is also set in order to use it for vm_ready? instead of the global domain instances have a label that identifies which project they belong to, so it can be used for FW rules
genebean
suggested changes
Dec 29, 2021
added 4 commits
December 29, 2021 12:02
on the rare occasion where adding a dns record and we get teh error it already exists assume that it is stale and replace it with the new IP
…being overwritten in the upstream vmpooler code, we use the global domain parameter, so naming that parameter the same in GCE. This parameter can be optionally set in the provider config, and overwrites the global parameter. It is used to infer the FQDN as .
sbeaulie
force-pushed
the
add-cloud-dns
branch
from
142c6d9 to
2cb2550
Compare
genebean
suggested changes
Jan 4, 2022
sbeaulie
force-pushed
the
add-cloud-dns
branch
from
65c9e55 to
b9b01f1
Compare
also changed from setting the project name in the instance labels to a instance tag aka network tag, as the setup for allowing traffic in the FW is bassed on tag not label
sbeaulie
force-pushed
the
add-cloud-dns
branch
from
b9b01f1 to
83770ac
Compare
genebean
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we setup DNS when a VM is created and tear it down when a VM is deleted
the DNS zone should exist already and is referenced by a provider setting
the dns zone is also set in order to use it for vm_ready? instead of the global
domain
instances have a label that identifies which project they belong to, so
it can be used for FW rules