Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RE-15161) Use timeout builtin to TCPSocket when opening sockets. #555

Merged
merged 5 commits into from
Mar 6, 2023
Merged

(RE-15161) Use timeout builtin to TCPSocket when opening sockets. #555

merged 5 commits into from
Mar 6, 2023

Conversation

isaac-hammes
Copy link
Contributor

No description provided.

@isaac-hammes isaac-hammes requested a review from a team as a code owner March 2, 2023 18:58
@isaac-hammes isaac-hammes force-pushed the change_timeout_method branch from bc662d6 to 1a75edc Compare March 2, 2023 19:14
@yachub yachub mentioned this pull request Mar 2, 2023
Merged
@yachub
Copy link

yachub commented Mar 4, 2023

To remove Timeout usage per https://github.com/mperham/connection_pool

WARNING: Don't ever use Timeout.timeout in your Ruby code or you will see occasional silent corruption and mysterious errors. The Timeout API is unsafe and cannot be used correctly, ever. Use proper socket timeout options as exposed by Net::HTTP, Redis, Dalli, etc.

@yachub yachub merged commit 9754c89 into main Mar 6, 2023
@yachub yachub deleted the change_timeout_method branch March 6, 2023 18:59
@yachub yachub added the enhancement New feature or request label Mar 6, 2023
@yachub yachub changed the title (maint) Use timeout builtin to TCPSocket when opening sockets. (RE-15161) Use timeout builtin to TCPSocket when opening sockets. Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yachub yachub yachub approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaac-hammes @yachub