Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update netcoredbg #530

Merged
merged 3 commits into from
Feb 19, 2022
Merged

Update netcoredbg #530

merged 3 commits into from
Feb 19, 2022

Conversation

puremourning
Copy link
Owner

closes #448

@puremourning
Copy link
Owner Author

This change is Reviewable

@puremourning
Fix different break behaviour with gcc8
cbba422 
Gcc 8 (or perhaps gdb, unsure) changed something in the dbeug info such
that there is now a breakpoint target on the opening brace of a
function, thus the function breakpoitns (and cpptools stop on entry)
behave differnently from clang and indeed from gcc on arm.

So we have to hack the tests to know that they are different. Sigh.

We also make the manual test container disable retries and use a
particular base dir by default. this is for convenience.
puremourning
puremourning commented Feb 19, 2022
View reviewed changes
Copy link
Owner Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @puremourning)

@mergify mergify bot merged commit 5e37e36 into master Feb 19, 2022
@mergify mergify bot deleted the update-netcoredbg branch February 19, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] update netcoredbg gadget to support exceptions
1 participant
@puremourning