Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade test; correct/add APIs #50

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Main focus of this PR was re-enabling the upgrade test I disabled temporarily in #48 by using Aff.

Along the way, I realized that the socket types should be upgraded to Socket TCP because (at least AFAICT) we don't expose a way to provide a different class than Socket. I also noticed that the ClientRequest type was missing its close event handler.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez merged commit 8bc2c73 into master Aug 1, 2023
1 check passed
@JordanMartinez JordanMartinez deleted the fix-upgrade-test branch August 1, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant