New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EventEmitter/EventHandle; fully-implement #14

Closed

JordanMartinez wants to merge 3 commits into master from update-to-event-emitter

Contributor

JordanMartinez commented Jun 27, 2023 •

edited

Loading

Description of the change

Format via purs-tidy
Add dependency on node-event-emitter
Fully implement net bindings
- Added bindings for BlockList and SocketAddress
- Worked around Socket TCP/IPC issue by forcing user to specify which connection type they'll use it for when creating the socket
- Defined rows for connect/listen options as these are sometimes used in the http2 connect function.

Checklist:

Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
Linked any existing issues or proposals that this pull request should close
Updated or added relevant documentation
Added a test for the contribution (if applicable)

JordanMartinez added 3 commits

June 27, 2023 10:03


          Format via purs-tidy

4900e80


          Add dependency on node-event-emitter

1672e43


          Fully implement net bindings

6cc6da4

JordanMartinez added the type: breaking change label

Contributor Author

JordanMartinez commented Jul 14, 2023

Superceded by #16

JordanMartinez closed this

JordanMartinez deleted the update-to-event-emitter branch

July 14, 2023 23:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: breaking change