Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type signatures of Data.List.NonEmpty.intersect and Data.List.NonEmpty.intersectBy to return a List instead of a NonEmptyList #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

evaogbe
Copy link

@evaogbe evaogbe commented Dec 14, 2023

Description of the change

Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.

Changed type signatures of Data.List.NonEmpty.intersect and Data.List.NonEmpty.intersectBy to return a List instead of a NonEmptyList. Fixes #216


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data.List.NonEmpty.intersect and Data.List.NonEmpty.intersectBy throw when intersection empty
2 participants