Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stripPrefix performs full linear search in order to check if index is 0 #123

Closed
natefaubion opened this issue May 11, 2020 · 0 comments · Fixed by #124
Closed

stripPrefix performs full linear search in order to check if index is 0 #123

natefaubion opened this issue May 11, 2020 · 0 comments · Fixed by #124

Comments

@natefaubion
Copy link
Contributor

Similar to purescript-contrib/purescript-parsing#92
@michaelficarra michaelficarra mentioned this issue May 12, 2020
Merged
garyb added a commit that referenced this issue May 13, 2020
@garyb
Merge pull request #124 from michaelficarra/GH-123
ec6da8f 
fixes #123: improve performance of stripPrefix/stripSuffix; add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@natefaubion