Always use forward slash as path separator in lockfile #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-f
reviewed
Aug 28, 2024
src/Spago/Config.purs
Outdated
| -- When writing lockfile, we specifically always use forward slash as path | ||
| -- separator to ensure that the lockfile doesn't keep changing when team | ||
| -- members run Spago on different platforms. | ||
| forwardSlashPath = path # String.replaceAll (String.Pattern Path.sep) (String.Replacement "/") |
There was a problem hiding this comment.
We have withForwardSlashes in the Prelude
There was a problem hiding this comment.
Oh indeed! Haven't noticed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #1158
Checklist:
[ ] Added some example of the new feature to theREADME