Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In PSA output label warnings and errors as such #1277

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

fsoikin
Copy link
Collaborator

@fsoikin fsoikin commented Aug 28, 2024

Description of the change

Fixes #1148

The outputs now look like:

[WARNING 1/4 ImplicitImport] src/Main.purs:3:1

[ERROR 1/2 TypesDoNotUnify] src/Foo.purs:4:5

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • [ ] Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

@f-f
Copy link
Member

f-f commented Aug 28, 2024

Patch is good, but I wonder if we should expand the texts to be WARNING and ERROR? It's no strong opinion though, just reads better to me.

@fsoikin
Copy link
Collaborator Author

fsoikin commented Aug 28, 2024

I have no strong opinion either. Changed to "ERROR" and "WARNING".

@f-f f-f merged commit 26ff517 into purescript:master Aug 29, 2024
5 checks passed
@fsoikin fsoikin deleted the warnings-errors-diff branch August 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spago doesn't tell what is a warning and what is an error
2 participants