-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Spago from a nested directory other than workspace root #1310
Open
fsoikin
wants to merge
32
commits into
purescript:master
Choose a base branch
from
fsoikin:nested-launch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fsoikin
commented
Feb 3, 2025
f-f
reviewed
Feb 8, 2025
All feedback addressed except the request to mention #951, because I didn't understand what it meant. |
Thank you @fsoikin for implementing this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #1237
Allowing Spago to be launched from a directory nested within the workspace.
spago.yaml
containing a workspace.spago.yaml
files back down the tree and loads those that it hasn't loaded while walking up.spago.yml
(wrong extension) files.spago.yaml
it sees. If this is not the root project, it will become "selected".-p
option. But on the other hand, it's very likely that if your CWD is a particular project, you're probably working on just that one.yml
files found along the way, if any, suggesting that they may have the wrong extension.Checklist:
[ ] Added some example of the new feature to theREADME