Add more useful comments in spago.dhall #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhall format no longer removes non-toplevel comments
f-f
reviewed
Apr 19, 2021
- Remove link to package sets project - change 'project' to 'documentation' for spago - Change dhall link to the Language Tour
- add spaces between brackets and its content
|
I've addressed your comments. |
f-f
approved these changes
Apr 20, 2021
|
When trying to build/test this locally, I ran into issues due to not having built a file for docs-search. The contributing file should be updated to clarify how to do this to make things easier for people. |
|
Latest commit fixes fixtures. Not sure if I got every one of them, but I think I did. |
|
Great, thank you! |
@JordanMartinez that's a great point - In the contributing file we do instruct to run |
|
@f-f Ah... No, it's clear enough. I just missed it because I skimmed it too quickly. I saw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #708
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊