Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes pod/kubelet sample YAML #100

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Add Kubernetes pod/kubelet sample YAML #100

merged 1 commit into from
Sep 14, 2017

Conversation

CallMeFoxie
Copy link
Collaborator

As title says, adds kubernetes static pod/kubelet static pod definition YAML.

purrplingcat
purrplingcat requested changes Sep 13, 2017
View reviewed changes
Copy link
Owner

@purrplingcat purrplingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move purrplingbot-kubernetes.yaml to extras/ folder. This folder is for examples, config snippets, templates, text resources and etc.

In README format keys aka _VERSION_ as code inline-block like a other examples in README and UPGRADING.md

purrplingcat
purrplingcat reviewed Sep 13, 2017
View reviewed changes
README.md Outdated

### Run via kubelet/static POD for Kubernetes
1. Download purrplingbot-kubernetes.yaml
2. Replace \__VERSION__ with desired version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format it as inline code block

purrplingbot-kubernetes.yaml Outdated
@@ -0,0 +1,26 @@
apiVersion: v1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this file to extras/ folder

@purrplingcat purrplingcat added this to the 1.3.0-beta3 milestone Sep 13, 2017
@CallMeFoxie
Copy link
Collaborator Author

Fixed and squished :)

purrplingcat
purrplingcat approved these changes Sep 14, 2017
View reviewed changes
Copy link
Owner

@purrplingcat purrplingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me 🐱

@purrplingcat purrplingcat merged commit 2b7c35b into purrplingcat:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purrplingcat purrplingcat purrplingcat approved these changes

Assignees

@CallMeFoxie CallMeFoxie

Labels
semantic:PullRequest type:Support
Projects
None yet
Milestone
1.3.0-beta3
Development

Successfully merging this pull request may close these issues.
2 participants
@CallMeFoxie @purrplingcat