consider int overflow

putdotio · Oct 16, 2020 · f68a872 · f68a872
1 parent d4da656
commit f68a872
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/property/biginteger.go b/internal/property/biginteger.go
@@ -35,12 +35,12 @@ func (t BigInteger) ConvertValue(v interface{}) (driver.Value, error) {
 	case int8:
 		return int64(i), nil
 	case uint:
-		if i > math.MaxInt64 {
+		if i > math.MaxUint32 {
 			return nil, fmt.Errorf("number is greater then max big_integer value: %v", v)
 		}
 		return int64(i), nil
 	case uint64:
-		if i > math.MaxInt64 {
+		if i > math.MaxUint64 {
 			return nil, fmt.Errorf("number is greater then max big_integer value: %v", v)
 		}
 		return int64(i), nil

diff --git a/internal/property/integer.go b/internal/property/integer.go
@@ -46,7 +46,7 @@ func (t Integer) int64(v interface{}) (int64, error) {
 	case int8:
 		return int64(i), nil
 	case uint:
-		if i > math.MaxInt64 {
+		if i > math.MaxUint32 {
 			return 0, fmt.Errorf("number is greater then max integer value: %v", v)
 		}
 		return int64(i), nil