Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary unescape function #114

Merged
merged 1 commit into from
Jan 25, 2020
Merged

remove unnecessary unescape function #114

merged 1 commit into from
Jan 25, 2020

Conversation

pveyes
Copy link
Owner

@pveyes pveyes commented Jan 23, 2020

Turns out this is unnecessary and introduces security risk

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #114 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #114      +/-   ##
=========================================
- Coverage   97.16%   97.1%   -0.07%     
=========================================
  Files           5       5              
  Lines         141     138       -3     
  Branches       47      47              
=========================================
- Hits          137     134       -3     
  Misses          2       2              
  Partials        2       2
Impacted Files Coverage Δ
src/browser.ts 98.33% <100%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a827808...6c63eb7. Read the comment docs.

@pveyes pveyes merged commit 1281bef into master Jan 25, 2020
@pveyes pveyes deleted the remove-unescape branch February 1, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant