Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix non-boolean attributes #138

Merged
merged 4 commits into from
Aug 6, 2021
Merged

fix non-boolean attributes #138

merged 4 commits into from
Aug 6, 2021

Conversation

pveyes
Copy link
Owner

@pveyes pveyes commented Aug 5, 2021 •
edited
Loading

fix #137

Use React DOMProperty for server bundle, and .setAttribute(attr, '') check for client bundle to minimize bundle size increase

@pveyes pveyes mentioned this pull request Aug 5, 2021
Closed
@pveyes pveyes changed the title test true string attribute fix non-boolean attributes Aug 5, 2021
@pveyes pveyes marked this pull request as ready for review August 5, 2021 14:30
@pveyes
Copy link
Owner Author

pveyes commented Aug 5, 2021

bundle size increases from 1.28kB to 1.42kB

@pveyes
Copy link
Owner Author

pveyes commented Aug 6, 2021 •
edited
Loading

bundle size increases from 1.28kB to 1.35 kB

@pveyes pveyes merged commit 94036ba into master Aug 6, 2021
@pveyes pveyes deleted the true-string-alt branch August 6, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with empty attributes
1 participant
@pveyes