Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Typings #89

Merged
merged 1 commit into from
May 9, 2019
Merged

Typescript Typings #89

merged 1 commit into from
May 9, 2019

Conversation

Arcath
Copy link
Contributor

@Arcath Arcath commented May 8, 2019

Following on from #86 this changes the way htmr is built from source.

Rollup is still used to create the browser bundled version.

tsc is used to create the server version. The lib directory is a copy of the src directory with a .js and .d.ts file for each .ts file in the source.

I modified server.ts to use export function as it wasn't outputting any typings. I also changed the function typing to Partial<HtmrOptions> so that it won't require a user to supply all the options if they only want one.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   98.57%   98.56%   -0.02%     
==========================================
  Files           5        5              
  Lines         140      139       -1     
  Branches       41       41              
==========================================
- Hits          138      137       -1     
  Misses          2        2
Impacted Files Coverage Δ
src/server.ts 97.77% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf25801...6f65a2e. Read the comment docs.

Copy link
Owner

@pveyes pveyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for improving the type for server.js 👍

@pveyes pveyes merged commit 49b0a82 into pveyes:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants