Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrieval function for horizon profile from MINES Paris Tech #1295

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Aug 26, 2021

  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

The proposed function retrieves the local horizon profile for a specific location (latitude, longitude, and elevation). The returned horizon profile has a resolution of 1 degree in the azimuth direction. The service is provided by MINES ParisTech though I cannot find any official documentation for it.

The function added in this PR (pvlib.iotools.get_mines_horizon) is very similar to the function added in #1395 (pvlib.iotools.get_pvgis_horizon).

@AdamRJensen
Copy link
Member Author

@mikofski @cwhanse I saw your discussions in #758 and #1290 and figured I'd share the code I had laying around for downloading the local horizon profile from SRTM. Does this have any interest to you?

@mikofski
Copy link
Member

I'm lovin' this! Could we also look into retrieving pvgis horizon data, how do they compare to the SRTM from MINES?

@bgpierc
Copy link
Contributor

bgpierc commented Mar 4, 2022

MINES appears to have slightly changed their API, we need to skip one more row (to 26)
horizon = pd.read_csv(io.StringIO(res.text), skiprows=26, nrows=360, delimiter=';')

@AdamRJensen
Copy link
Member Author

AdamRJensen commented Mar 11, 2022

Thank you @bgpierc! If you are already using it, I'd be happy to hear if you find it useful and how it may compare to other sources you are using.

Within a month or so I'll return and hopefully finish this PR fyi.

@bgpierc
Copy link
Contributor

bgpierc commented Mar 14, 2022

Thanks, I've implemented a similar function to pull from pvgis and one to calculate directly from a DEM in #1395, all three methods appear to line up well (within ~2 degrees MAE) with each other and field data I've taken, so it's looking good

@AdamRJensen AdamRJensen marked this pull request as draft August 5, 2022 16:01
@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels Aug 16, 2022
@AdamRJensen AdamRJensen closed this by deleting the head repository Dec 5, 2022
@AdamRJensen AdamRJensen reopened this May 28, 2023
@AdamRJensen AdamRJensen added this to the 0.10.0 milestone May 28, 2023
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels May 28, 2023
@AdamRJensen AdamRJensen marked this pull request as ready for review May 28, 2023 09:48
@AdamRJensen AdamRJensen changed the title Add retrieval function for SRTM horizon profile Add retrieval function for horizon profile from MINES Paris Tech May 28, 2023
@AdamRJensen
Copy link
Member Author

@YvesMSaintDrenan Are you ok with adding this function to pvlib?

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service is provided by MINES ParisTech though I cannot find any official documentation for it.

Nor can I. After quite some digging, all I could find is this: http://toolbox.1.webservice-energy.org/service/wps?SERVICE=WPS&Request=DescribeProcess&Identifier=compute_horizon_srtm&version=1.0.0

I'm reluctant to merge this PR without something satisfying in the References section :/

pvlib/iotools/sodapro.py Outdated Show resolved Hide resolved
pvlib/iotools/sodapro.py Outdated Show resolved Hide resolved
pvlib/iotools/sodapro.py Outdated Show resolved Hide resolved
pvlib/iotools/sodapro.py Outdated Show resolved Hide resolved
AdamRJensen and others added 2 commits June 8, 2023 16:03
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@AdamRJensen
Copy link
Member Author

I'm reluctant to merge this PR without something satisfying in the References section :/

The service has a notably better azimuthal resolution than PVGIS, but I agree that the missing documentation is a bummer.

@YvesMSaintDrenan could you perhaps add a subpage to the SoDa Pro website or upload a short note describing the service somewhere?

@kandersolar kandersolar modified the milestones: 0.10.0, v0.10.2 Jul 6, 2023
@kandersolar kandersolar modified the milestones: v0.10.2, Someday Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants