Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI asv check #1454

Merged
merged 7 commits into from
May 4, 2022
Merged

CI asv check #1454

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62552b7
CI asv check
roger-lcc Apr 27, 2022
777e42e
added CI asv check
roger-lcc Apr 27, 2022
47a4fd0
CI asv check
roger-lcc Apr 27, 2022
2bb9526
CI asv check
roger-lcc Apr 27, 2022
6991cd8
updated CI asv check
roger-lcc Apr 27, 2022
28d7f3c
Update docs/sphinx/source/whatsnew/v0.9.2.rst
roger-lcc Apr 28, 2022
2bbbfcf
Merge branch 'master' into CI
roger-lcc Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/asv_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: asv

# CI ASV CHECK is aimed to verify that the benchmarks execute without error.
on: [pull_request, push]
Comment on lines +3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanderso-nrel do we really need this on push? I was surprised to push a branch to my fork and then get a notification that the test was done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be nice to run it on pushes to master. I didn't consider the effect on forks. Fine with me to change it to something like this:

on:
  push:
    branches:
    - master
  pull_request:


jobs:
quick:
runs-on: ubuntu-latest
defaults:
run:
shell: bash -el {0}

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Install Python
uses: actions/setup-python@v3
with:
python-version: '3.9.7'

- name: Install asv
run: pip install asv==0.4.2

- name: Run asv benchmarks
run: |
cd benchmarks
asv machine --yes
asv run --quick --dry-run --show-stderr | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
kandersolar marked this conversation as resolved.
Show resolved Hide resolved
if grep "failed" benchmarks.log > /dev/null ; then
exit 1
fi

2 changes: 2 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ Benchmarking
~~~~~~~~~~~~~
* Updated version of numba in asv.conf from 0.36.1 to 0.40.0 to solve numba/numpy conflict. (:issue:`1439`, :pull:`1440`)
Requirements
* Added a basic CI asv check(:issue:`1446`, :pull:`1454`)
~~~~~~~~~~~~
roger-lcc marked this conversation as resolved.
Show resolved Hide resolved

Contributors
~~~~~~~~~~~~
* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)
* Chencheng Luo (:ghuser:`roger-lcc`)