Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.12 to CI #1886

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Add python 3.12 to CI #1886

merged 9 commits into from
Dec 12, 2023

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Oct 10, 2023 •
edited
Loading

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added testing remote-data triggers --remote-data pytests labels Oct 10, 2023
@kandersolar kandersolar added this to the v0.10.3 milestone Oct 10, 2023
@kandersolar kandersolar marked this pull request as ready for review October 19, 2023 14:37
@cwhanse cwhanse mentioned this pull request Dec 8, 2023
Closed
15 tasks
AdamRJensen
AdamRJensen approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kandersolar kandersolar merged commit 304fbb5 into pvlib:main Dec 12, 2023
34 checks passed
@kandersolar kandersolar deleted the py312 branch December 12, 2023 19:31
@kandersolar kandersolar mentioned this pull request Dec 14, 2023
Merged
8 tasks
@kandersolar kandersolar mentioned this pull request Feb 6, 2024
Merged
8 tasks
@kandersolar kandersolar mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamRJensen AdamRJensen AdamRJensen approved these changes

Assignees
No one assigned
Labels
remote-data triggers --remote-data pytests testing
Projects
None yet
Milestone
v0.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@kandersolar @AdamRJensen