Fix spurious test error with pandas 2.1 #1891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.As mentioned in #1827 (comment), a pyephem test is failing due to a units difference in pandas datetimes (example failure):
I think this pandas issue describes the problem: pandas-dev/pandas#55014
In short, the way we construct the expected value in the test results in different units for different pandas versions, and that causes the test to fail.
What I don't understand is why it only affects theah of course, it's because pyephem is optional and not installed in the "bare" jobs.conda
CI jobs.Anyway I hope this change gets the tests passing again.