Implement reverse transposition using Perez-Driesse forward transposition

[adriesse]

• Closes Demonstrate reverse transposition using Perez-Driesse forward transposition #1901
• I am familiar with the contributing guidelines
• Tests added
• Updates entries in docs/sphinx/source/reference for API changes.
• Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
• New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
• Pull request is nearly complete and ready for detailed review.
• Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

[adriesse]

The function works, for anyone who wants to play with it already. The discussion about suitable function names is now open!

[kandersolar]

Nice PR! Here are a few quick comments.

[adriesse]

@pvlib/pvlib-maintainer it is unclear whether potential reviewers are actually aware that this PR is ready for review. Is there any way to tell?

[cwhanse]

Thanks @adriesse looks pretty good to me.

[adriesse]

@AdamRJensen Do you think we will have the final form of the paper reference in time for the December release?

[AdamRJensen]

@AdamRJensen Do you think we will have the final form of the paper reference in time for the December release?

I'm a bit puzzled that it is not out yet, but I expect it soon. At the very least we can add the doi: https://doi.org/10.1016/j.solener.2023.112093

[adriesse]

So to wrap this up I would:

• do a global change of "rtranspose" to "ghi_from_poa"
• add the DOI to the references

Anything else needed?

[adriesse]

Wow, do I get a badge for making changes that do not trigger Flake8 ??

[adriesse]

Ready to merge?

[adriesse]

I guess I'll wait a bit in case more reviews trickle in. It ain't over 'til it's over.

[AdamRJensen]

For the reverse transposition example it would be great to incorporate the GTI_DIRINT function, if anything, at least mention that pvlib offers two reverse transposition algorithms.

[adriesse]

For the reverse transposition example it would be great to incorporate the GTI_DIRINT function, if anything, at least mention that pvlib offers two reverse transposition algorithms.

I put in a mention and a reference.

[adriesse]

I guess I'll wait a bit in case more reviews trickle. It ain't over 'til it's over.

It's over!

[adriesse]

@AdamRJensen Do you think we will have the final form of the paper reference in time for the December release?

I'm a bit puzzled that it is not out yet, but I expect it soon. At the very least we can add the doi: https://doi.org/10.1016/j.solener.2023.112093

In case anyone missed it, the link works now.

[adriesse]

My plan is to send a thank-you note to NumFocus after this is merged.

[kandersolar]

A couple updates needed for the new function name but otherwise LGTM, thanks @adriesse!

My plan is to send a thank-you note to NumFocus after this is merged.

Lovely :) This PR is the last deliverable for the NF grant, right?

[adriesse]

A couple updates needed for the new function name but otherwise LGTM, thanks @adriesse!

My plan is to send a thank-you note to NumFocus after this is merged.

Lovely :) This PR is the last deliverable for the NF grant, right?

That's right, on time and on budget. :)

[adriesse]

Thanks @ALL!!