Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to generate Mi Bindkey with Password #3

Closed
wants to merge 3 commits into from
Closed

Added option to generate Mi Bindkey with Password #3

wants to merge 3 commits into from

Conversation

JsBergbau
Copy link

Added option added to generate Mi Bindkey with Password as described here pvvx/ATC_MiThermometer#94 (comment)

@JsBergbau
Copy link
Author

Hi @pvvx ,
what do you need or can I do that you can merge this pull request and thus integrate mi bindkey generation of password? This is just an addidional feature so bind key can also be set like before.

@pvvx
Copy link
Owner

pvvx commented Jun 1, 2021

Inappropriate license for argon2-bundled.min.js:
"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
There is no such part in my antics.
This is a bomb planted by open source traitor Linus Torvalds, who created conditions for the dissemination of information.
You must include all your teachers and parents. Otherwise, this license is invalid.

@JsBergbau
Copy link
Author

This license text is included in argon2-bundled.min.js so I thought this is sufficient, because argon2-bundled.min.js is a software on its own....

@JsBergbau
Copy link
Author

So it is ok how the license is included in the file itself?
Or would it help to fetch the file from somewhere else, like a CDN?

@JsBergbau
Copy link
Author

@pvvx What can I do that it can be integrated to generate MiBindKey from password? How can I help you?

@JsBergbau
Copy link
Author

@pvvx I'd really like to support the new encrypted format and generate the bindkey via a simple password. So it would be really great when this pull request can be integrated. So please just tell me what can I do, that you can integrate it. Thank you very much in advance.

@h1618
Copy link

h1618 commented Jun 20, 2021

Inappropriate license for argon2-bundled.min.js:
"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
There is no such part in my antics.
This is a bomb planted by open source traitor Linus Torvalds, who created conditions for the dissemination of information.
You must include all your teachers and parents. Otherwise, this license is invalid.

Excuse me, but this is bullshit. This wording is verbatim from the MIT License. You may not like it, but it is far more liberal than the GPL - and it has nothing to do with Linus Torvalds.

@JsBergbau
Copy link
Author

@pvvx Hi Victor,
can you have a look again at this pull request? What do you need / can I do to get this integrated? There's the request to support encrypted ATC format JsBergbau/MiTemperature2#93 and I'd like to add support for encrypted ATC format with bindkey direct and bindkey derived of password.

@rocket59
Copy link

Hi @pvvx first off many thanks for your work in improving on ATC'S firmware! A cool and cheap thermometer now made much better!

As I raised the issue of using encrypted advertisements on @JsBergbau's git page, I would like to add my support to adding password bindkey generation to the flasher to make it easier to make the transmissions more secure. Thanks for considering!

@JsBergbau JsBergbau closed this by deleting the head repository Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants