Skip to content

Commit

Permalink
Hot Fix for SW Card (#4467)
Browse files Browse the repository at this point in the history
Incorrect Icon fixed for "has service worker" and made the text lower
case

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Justin Willis <jgw9617@gmail.com>
Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com>
Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com>
Co-authored-by: Mara'ah Lee <maraahlee@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com>
Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com>
Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
Co-authored-by: Beth Pan <xupa@microsoft.com>
Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com>
Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com>
Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com>
Co-authored-by: Toby Liu <ybot1122@gmail.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com>
Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com>
  • Loading branch information
18 people authored Oct 16, 2023
1 parent a26ff48 commit 6c0caf4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
16 changes: 6 additions & 10 deletions apps/pwabuilder/public/assets/new/has_service_worker_icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 2 additions & 3 deletions apps/pwabuilder/src/script/pages/app-report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1375,7 +1375,6 @@ export class AppReport extends LitElement {
}
.gap {
gap: .5em;
}
sl-tooltip::part(base){
--sl-tooltip-font-size: 14px;
Expand Down Expand Up @@ -2146,7 +2145,7 @@ export class AppReport extends LitElement {
manifest = {};
todos.push({"card": "mani-details", "field": "Open Manifest Modal", "fix": "Edit and download your created manifest (Manifest not found before detection tests timed out)", "status": "missing"});
}

manifest = JSON.parse(sessionStorage.getItem("PWABuilderManifest")!).manifest;
this.validationResults = await validateManifest(manifest, true);

Expand Down Expand Up @@ -2538,7 +2537,7 @@ export class AppReport extends LitElement {

formatSWStrings(member: string){
const words = member.split('_');
const capitalizedWords = words.map(word => word.charAt(0).toUpperCase() + word.slice(1));
const capitalizedWords = words.map(word => word.toLowerCase());
const joined = capitalizedWords.join(" ");
return joined;
}
Expand Down

0 comments on commit 6c0caf4

Please sign in to comment.