Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWA Builder]: 'Required' information is not announced by the narrator in the name edit field. #4265

Closed
Anshi0420 opened this issue Aug 10, 2023 · 8 comments · Fixed by #4368
Closed

[PWA Builder]: 'Required' information is not announced by the narrator in the name edit field. #4265

Anshi0420 opened this issue Aug 10, 2023 · 8 comments · Fixed by #4368
Assignees
@maraah1
Labels
A11ySev2 Accessibility Team tag - P2 items A11yTTValidated Accessibility team tag for closed bugs A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 CT-June24 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web

Comments

@Anshi0420
Copy link
Collaborator

What happened?

Narrator is not announcing the required information in the Name edit field present inside the Edit Your Manifest dialogue, it only announces the label and role.

How do we reproduce the behavior?

Repro Steps:

  1. Open the PWA Builder URL in Anaheim dev browser.
  2. PWA Builder page will appear.
  3. Navigate to the 'Edit your Manifest' button activate it.
  4. Turn on narrator using Ctrl + Win + Enter key.
  5. Navigate to the name edit field.
  6. Observe the narrator's announcement.

What do you expect to happen?

Narrator must announce the required information along with the name and role of the Name edit field.
Aria Required property must be present for the name edit field.

What environment were you using?

Test Environment:
OS Build: Windows 11 Enterprise Insider Preview 22H2 (23493.1000)
Edge Browser: Version 115.0.1880.3 (Official build) dev (64-bit)
User ID: V-
URL: https://www.pwabuilder.com/reportcard?site=https://webboard.app
Screen Reader: Narrator

Additional context

Note:

  1. Issue is repro for the edit field where required information is present.
  2. Issue is also repro at https://www.pwabuilder.com/reportcard?site=https://example.com

User Experience:
If the required information will not be announced by the screen readers, then users dependent on it will not get the information that the edit field is mandatory to fill, and they will not get the proper information of the UI.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

Attachments:

2023-08-10.23-09-43.mp4

Code_Snip
@Anshi0420 Anshi0420 added bug 🐛 needs triage 🔍 A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft A11ySev2 Accessibility Team tag - P2 items Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team HCL-E+D CT-July23 labels Aug 10, 2023
@Suriya617 Suriya617 mentioned this issue Aug 17, 2023
Closed
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

2 similar comments
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Jaylyn-Barbee Jaylyn-Barbee changed the title [PWA Builder-Blog]: 'Required' information is not announced by the narrator in the name edit field. [PWA Builder]: 'Required' information is not announced by the narrator in the name edit field. Aug 28, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@maraah1 maraah1 mentioned this issue Sep 8, 2023
Merged
3 tasks
@maraah1 maraah1 moved this to In Review 🤔 in PWABuilder Sep 8, 2023
@maraah1 maraah1 self-assigned this Sep 8, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

github-merge-queue bot pushed a commit that referenced this issue Sep 18, 2023
@maraah1 @Jaylyn-Barbee
required label add (#4368)
570a90a 
fixes #4265 
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->


## Describe the new behavior?


## PR Checklist

- [ ] Test: run `npm run test` and ensure that all tests pass
- [ ] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ ] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information

Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com>
@maraah1
Copy link
Collaborator

maraah1 commented Sep 20, 2023

Changes merged

@maraah1 maraah1 closed this as completed Sep 20, 2023
@github-project-automation github-project-automation bot moved this from In Review 🤔 to Done ✔️ in PWABuilder Sep 20, 2023
@Anshi0420
Copy link
Collaborator Author

This issue is still repro at the latest environment.
https://www.pwabuilder.com/reportcard?site=https://webboard.app

2024-06-26.12-21-48.mp4

@Anshi0420 Anshi0420 reopened this Jun 26, 2024
@github-project-automation github-project-automation bot moved this from Done ✔️ to Todo 📃 in PWABuilder Jun 26, 2024
@Suriya617 Suriya617 mentioned this issue Jun 27, 2024
Closed
@Suriya617
Copy link
Collaborator

As these are not reflecting in scorecard. Tracking with #4762

@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in PWABuilder Jun 28, 2024
@Suriya617 Suriya617 added the A11yTTValidated Accessibility team tag for closed bugs label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraah1 maraah1

Labels
A11ySev2 Accessibility Team tag - P2 items A11yTTValidated Accessibility team tag for closed bugs A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 CT-June24 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web
Projects
PWABuilder
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

required label add pwa-builder/PWABuilder
3 participants
@maraah1 @Suriya617 @Anshi0420