Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Removing all categories doesn't properly update manifest. #4610

Closed
zateutsch opened this issue Jan 16, 2024 · 0 comments
Closed

[BUG] Removing all categories doesn't properly update manifest. #4610

zateutsch opened this issue Jan 16, 2024 · 0 comments
Assignees
@zateutsch
Labels
bug 🐛 site

Comments

@zateutsch
Copy link
Contributor

What happened?

Adding categories and then removing them all doesn't properly update manifest:

image
And then:
image

How do we reproduce the behavior?

  1. Open manifest editor.
  2. Add categories.
  3. Remove categories.
  4. Last removed category still shows in the code editor.

What do you expect to happen?

Categories array is removed from code editor view.

What environment were you using?

OS: Windows 11
Browser: Edge

Additional context

Related to #4172.

I'll take care of this.
@zateutsch zateutsch self-assigned this Jan 16, 2024
@zateutsch zateutsch mentioned this issue Jan 16, 2024
Merged
@zateutsch zateutsch moved this to In Review 🤔 in PWABuilder Jan 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2024
@zateutsch @jgw96
#4172/4610/4612: Manifest Editor bug fixes (#4615)
5daf5d1 
fixes #4172
fixes #4610 
fixes #4612

Fixed a few bugs with how errors are displayed in the manifest editor.

I had to change the manifest tests a little to get this to work as
expected, so @jgw96 or @Jaylyn-Barbee one of y'all should probably take
a close look at this PR to make sure I didn't cause anything unexpected.

---------

Co-authored-by: Justin Willis <jgw9617@gmail.com>
@github-project-automation github-project-automation bot moved this from In Review 🤔 to Done ✔️ in PWABuilder Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zateutsch zateutsch

Labels
bug 🐛 site
Projects
PWABuilder
Status: Done ✔️
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zateutsch