Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Removed close button from portals modal #4326

Merged
merged 2 commits into from
Aug 28, 2023
Merged

[Accessibility] Removed close button from portals modal #4326

merged 2 commits into from
Aug 28, 2023

Conversation

Jaylyn-Barbee
Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee commented Aug 28, 2023 •
edited
Loading

fixes #4238

PR Type

Bugfix

Describe the current behavior?

X button on portals pop up even tho you can't X it out

Describe the new behavior?

Removed the X

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@microsoft-github-policy-service
Copy link
Contributor

Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Jaylyn-Barbee Jaylyn-Barbee changed the title Removed closed button from portals modal [Accessibility] Removed closed button from portals modal Aug 28, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4326.centralus.2.azurestaticapps.net

@Jaylyn-Barbee Jaylyn-Barbee changed the title [Accessibility] Removed closed button from portals modal [Accessibility] Removed close button from portals modal Aug 28, 2023
zateutsch
zateutsch approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@zateutsch zateutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya ya ya ya

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Aug 28, 2023
Merged via the queue into staging with commit 701704b Aug 28, 2023
@Jaylyn-Barbee Jaylyn-Barbee deleted the jay/remove-x-from-portals branch August 28, 2023 20:19
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4326.centralus.2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zateutsch zateutsch zateutsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaylyn-Barbee @zateutsch