Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Fixed focus no appearing on black buttons and label on input box in Image Gen page. #4335

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

Jaylyn-Barbee
Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee commented Aug 30, 2023

fixes #4229, #4218 and #4228

PR Type

Bugfix

Describe the current behavior?

  1. For the padding input on the image gen page there was no accessible label
  2. For some of our black buttons the focus ring wasn't showing when tabbed over
  3. Incorrect aria roles defined

Describe the new behavior?

  1. Input has a label
  2. New visible focus ring.
  3. Removed unnecessary definitions of role.

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@microsoft-github-policy-service
Copy link
Contributor

Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Aug 30, 2023
Merged via the queue into staging with commit fbc8643 Aug 30, 2023
@Jaylyn-Barbee Jaylyn-Barbee deleted the jay/accessibility-updates-8.30 branch August 30, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants