-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
color ratio fix #4344
color ratio fix #4344
Conversation
Thanks maraah1 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maraah1, I imagine all buttons that had the old look will need to be updated whether or not they were mentioned in the original issue, ie:
Lets go ahead and update any other buttons we can find and have @zateutsch review to make sure he's cool with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maraah1 @Jaylyn-Barbee Is there a quick way to check color contrast ratio? I can go through and fix the colors for the whole site, and also double check that everything still looks nice together. |
@zateutsch if you run the fast pass from the accessibility insights Edge extension, there is a tab that has a few color contrast call outs |
fixes #[issue number]
#4277
PR Type
Bugfix
Describe the current behavior?
Describe the new behavior?
PR Checklist
npm run test
and ensure that all tests passAdditional Information