Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color ratio fix #4344

Merged
merged 2 commits into from
Sep 5, 2023
Merged

color ratio fix #4344

merged 2 commits into from
Sep 5, 2023

Conversation

maraah1
Copy link
Collaborator

@maraah1 maraah1 commented Aug 31, 2023

fixes #[issue number]
#4277

PR Type

Bugfix

Describe the current behavior?

Describe the new behavior?

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@microsoft-github-policy-service
Copy link
Contributor

Thanks maraah1 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the updated look.
image

@maraah1, I imagine all buttons that had the old look will need to be updated whether or not they were mentioned in the original issue, ie:
image

Lets go ahead and update any other buttons we can find and have @zateutsch review to make sure he's cool with the changes.

Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zateutsch
Copy link
Contributor

@maraah1 @Jaylyn-Barbee Is there a quick way to check color contrast ratio? I can go through and fix the colors for the whole site, and also double check that everything still looks nice together.

@Jaylyn-Barbee
Copy link
Contributor

@zateutsch if you run the fast pass from the accessibility insights Edge extension, there is a tab that has a few color contrast call outs

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Sep 5, 2023
Merged via the queue into staging with commit d8a5262 Sep 5, 2023
@Jaylyn-Barbee Jaylyn-Barbee deleted the color-contrast-fix branch September 5, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants