Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(manifest): correct launch-handler array #4365

Merged
merged 2 commits into from
Sep 18, 2023
Merged

docs(manifest): correct launch-handler array #4365

merged 2 commits into from
Sep 18, 2023

Conversation

dargmuesli
Copy link
Contributor

PR Type

Documentation content changes

Describe the current behavior?

The array values are not properly separated.

Describe the new behavior?

The array values are properly separated.

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

n/a

@microsoft-github-policy-service
Copy link
Contributor

Thanks dargmuesli for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zateutsch should we merge to staging first?

@zateutsch zateutsch changed the base branch from main to staging September 8, 2023 18:17
@zateutsch
Copy link
Contributor

@zateutsch should we merge to staging first?

Yeah, I retargeted.

Copy link
Contributor

@zateutsch zateutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Appreciate your help.

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Sep 18, 2023
Merged via the queue into pwa-builder:staging with commit 10cd849 Sep 18, 2023
1 check passed
@dargmuesli dargmuesli deleted the patch-1 branch September 18, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants