Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing alt add for all docs #4387

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Missing alt add for all docs #4387

merged 2 commits into from
Sep 25, 2023

Conversation

maraah1
Copy link
Collaborator

@maraah1 maraah1 commented Sep 20, 2023

fixes #4259

PR Type

Bugfix

Describe the current behavior?

Describe the new behavior?

Alt added to images throughout docs

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@microsoft-github-policy-service
Copy link
Contributor

Thanks maraah1 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@maraah1 maraah1 self-assigned this Sep 20, 2023
accesslint[bot]
accesslint bot reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

apps/pwabuilder/src/script/pages/image-generator.ts Outdated Show resolved Hide resolved
@maraah1 maraah1 changed the base branch from main to staging September 21, 2023 01:45
accesslint[bot]
accesslint bot reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Sep 25, 2023
Merged via the queue into staging with commit e0cba3c Sep 25, 2023
@Jaylyn-Barbee Jaylyn-Barbee deleted the missing-alt-add branch September 25, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

@Jaylyn-Barbee Jaylyn-Barbee Jaylyn-Barbee approved these changes

Assignees

@maraah1 maraah1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS]: Ensures <img> elements have alternate text or a role of none or presentation.
2 participants
@maraah1 @Jaylyn-Barbee