Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field names #46

Closed
LoranRendel opened this issue Mar 5, 2020 · 1 comment
Closed

Field names #46

LoranRendel opened this issue Mar 5, 2020 · 1 comment

Comments

@LoranRendel
Copy link

Plugin doesnt work with fields/groups containing : or . in name attribute.
WPCF7 works with these fields well.

https://www.w3.org/TR/html401/types.html#type-name

Fix:
jQuery('[data-id="' + condition.then_field + '"]'
instead of
jQuery('[data-id=' + condition.then_field + ']'

@pwkip
Copy link
Owner

pwkip commented Apr 11, 2020

Thanks, will be fixed in the next version.

@pwkip pwkip closed this as completed Apr 11, 2020
pwkip added a commit that referenced this issue Apr 17, 2020
* Tested with WP 5.4
* fix multiselect
* fix required file field inside mutistep
* allow group names to contain `.` and `:` (#46)
* fix possible conflicts with require_once 'init.php' (https://wordpress.org/support/topic/conflict-with-theme-because-of-require_once/)
* Created some unit tests and integration tests, so hopefully no more regression bugs from now on! (next step: automated CI before publish)
* Got rid of warnings and notices when creating a new form.
* Fix small clear_on_hide bug with select field (#51)
* PRO: fix "not empty" when using first_as_label in select field. (closes guthub issue #48)
* PRO: fix error with nested repeater buttons text
* PRO: new version of plugin_update_checker, compatible with PHP 7.3+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants