Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use children as field name #74

Closed
pwkip opened this issue Feb 19, 2021 · 3 comments
Closed

Cannot use children as field name #74

pwkip opened this issue Feb 19, 2021 · 3 comments
Labels
bug

Comments

@pwkip
Copy link
Owner

pwkip commented Feb 19, 2021

https://wordpress.org/support/topic/cannot-use-children-as-field-name/
@pwkip
Copy link
Owner Author

pwkip commented Apr 20, 2021

https://wordpress.org/support/topic/children-field-name-conflict/

@pwkip pwkip added the bug label Apr 16, 2022
@pwkip
Copy link
Owner Author

pwkip commented Apr 18, 2022

This SO question describes the root of the problem: https://stackoverflow.com/questions/71906515/cant-use-element-children-when-one-of-the-child-nodes-has-name-children

More interesting reading about HTMLFormElement: https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement

Maybe there is a way to convert HTMLFormElement to a regular HTMLElement, that way the "children" problem might be solved..

@pwkip
Copy link
Owner Author

pwkip commented Apr 23, 2022

Fixed in version 2.1.4

@pwkip pwkip closed this as completed Apr 23, 2022
pwkip added a commit that referenced this issue May 16, 2022
@pwkip
= 2.1.4 (2022-05-16) =
0ad4ea4 
* It's no longer needed to save the form before adding conditions. Available groups are updated instantaneously after adding/changing them in the form editor.
* Fix problems when group is named "children" [GH issue 74](#74)
* Fix problems with unsaved changes notice [GH issue 91](#91)
* Tested up to WP 6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pwkip