Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended version of $(document).ready #111

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

hirasso
Copy link
Contributor

@hirasso hirasso commented Sep 5, 2023

Hi there! First of all, thank you so much for this very handy plugin! ❤️

Today I noticed that the initialization in scripts_admin.js didn't fire on one of my sites:

jQuery(document).on('ready', function() {...})

Changing it to the recommended way fixed the plugin for me:

jQuery(document).ready(function() {...})

I don't have the issue on all of my sites using your plugin, but I still think it's worth it to use the official jQuery-way for initializing the script.

@hirasso
Copy link
Contributor Author

hirasso commented Oct 30, 2023

@pwkip any chance this would be merged? Otherwise I'll close it :)

@pwkip
Copy link
Owner

pwkip commented Oct 31, 2023

Still need to review this, but currently not much time. You can leave it open. And thanks!

@pwkip pwkip merged commit 185d786 into pwkip:master Nov 13, 2023
pwkip added a commit that referenced this pull request Nov 13, 2023
* Removed webpack build. (This might cause JS errors in outdated browsers.)
* Fix admin validator Error. Thanks to [joostdekeijzer](#113)
* Fix some jQuery code. Thanks to [hirasso](#111)
@hirasso hirasso deleted the fix/document-ready branch November 13, 2023 09:10
@hirasso
Copy link
Contributor Author

hirasso commented Nov 13, 2023

Thanks so much for merging! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants