Minor changes #86
Merged
Minor changes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable $_POST in isset() always exists and is not nullable.
getConditions() is checking array or not.
|
Thanks for this PR @arshidkv12 . I see you did a bit of cleanup, but could you explain in a couple of words what changes you made, and why? Did the code trigger any notices/errors before these changes? |
|
Please check related comments. |
pwkip
reviewed
Jan 21, 2022
| @@ -177,7 +177,7 @@ function wpcf7cf_after_save($contact_form) { | |||
| function wpcf7cf_save_contact_form( $contact_form ) | |||
| { | |||
|
|
|||
| if ( ! isset( $_POST ) || empty( $_POST ) || ! isset( $_POST['wpcf7cf-settings-text'] ) ) { | |||
There was a problem hiding this comment.
Need to keep this for usage in end to end tests and when calling methods directly from command line.
pwkip
reviewed
Jan 21, 2022
| @@ -205,8 +205,6 @@ function wpcf7cf_input_field($slug, $args) { | |||
| $args = wp_parse_args( $args, $defaults ); | |||
| extract($args); | |||
|
|
|||
| $label; $description; $default; $label_editable; | |||
There was a problem hiding this comment.
keeping this as a helper for development.
pwkip
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.