-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include type defintion #20
base: master
Are you sure you want to change the base?
Conversation
I'm not definitely saying no to this patch, but is there another way of accomplishing its goal? Does TypeScript really expect to creep into every package in your system? |
yeah, there is a typings manager but the most seamless way is having the repo itself provide the types so there won't be any version conflicts. soon we won't need |
This repo's goal is to implement the W3C XHR2 spec. Given the state of the spec, it is unlikely that the public API provided by the repo will ever change. Based on the |
Just to be clear about my intentions: I don't want to make your life hard on purpose. I'm pushing back because I'm not too thrilled about potentially having to include dedicated code for every language that compiles to JS out there. If the alternative has a terrible price (e.g., if every Angular user has to create that |
every angular (ember is also going to use typescript) users would have to do a |
87803a9
to
6b90a5d
Compare
I need this for Universal Angular 2 which uses typescript
update: could you also release a patch update