Fix 'TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters'

Cakefile

@@ -20,7 +20,7 @@ task 'test', ->
       ssl_cert ->
         test_cases = glob.sync 'test/js/**/*_test.js'
         test_cases.sort()  # Consistent test case order.
-        run 'node_modules/.bin/mocha --colors --slow 200 --timeout 1000 ' +
+        run 'node_modules/.bin/mocha --colors --slow 200 --timeout 1000 --exit ' +
             "--require test/js/helpers/setup.js #{test_cases.join(' ')}"
 
 task 'webtest', ->

package.json

@@ -26,7 +26,9 @@
   "engines": {
     "node": ">= 6"
   },
-  "dependencies": {},
+  "dependencies": {
+    "native-url": "^0.3.4"
+  },
   "devDependencies": {
     "async": ">=3.0.1",
     "chai": ">=4.2.0",

src/001-xml_http_request.coffee

@@ -6,7 +6,7 @@
 http = require 'http'
 https = require 'https'
 os = require 'os'
-url = require 'url'
+url = require 'native-url'
 
 # The ECMAScript HTTP API.
 #
@@ -105,6 +105,8 @@ class XMLHttpRequest extends XMLHttpRequestEventTarget
       throw new SecurityError "HTTP method #{method} is not allowed in XHR"
 
     xhrUrl = @_parseUrl url
+    xhrUrl.path = encodeURI xhrUrl.path
+
     async = true if async is undefined
 
     switch @readyState

test/src/helpers/xhr_server.coffee

@@ -95,6 +95,10 @@ class XhrServer
         response.write json.body if json.body
         response.end()
 
+    # Returns a given URL parameter. Used for URL encoding testing.
+    @app.all '/_/url/:arg', (request, response) =>
+      response.json request.params.arg
+
     # Sends data in small chunks. Used for event testing.
     @app.post '/_/drip', (request, response) ->
       request.connection.setNoDelay()

test/src/xhr_test.coffee

@@ -70,6 +70,28 @@ describe 'XMLHttpRequest', ->
           done()
         @xhr.send()
 
+    describe 'on an unencoded URL', ->
+      beforeEach ->
+        @xhr.open 'GET', 'http://localhost:8912/_/url/💻'
+
+      it 'encodes correctly', (done) ->
+        @xhr.onload = (event) =>
+          expect(@xhr.status).to.equal 200
+          expect(@xhr.responseText).to.equal '"💻"'
+          done()
+        @xhr.send()
+
+    describe 'on an encoded URL', ->
+      beforeEach ->
+        @xhr.open 'GET', 'http://localhost:8912/_/url/%F0%9F%92%BB'
+
+      it 'does not double-encode', (done) ->
+        @xhr.onload = (event) =>
+          expect(@xhr.status).to.equal 200
+          expect(@xhr.responseText).to.equal '"💻"'
+          done()
+        @xhr.send()
+
   describe 'on a local gopher GET', ->
     describe '#open + #send', ->
       it 'throw a NetworkError', ->