Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better hooks for local files #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mitar
Copy link

@mitar mitar commented Sep 19, 2014

Cleaned up for hooks for local files. It can now support both local files and relative URLs.

@PatrickJS
Copy link

this might be necessary for Ionic loading files from Cordova

@pwnall
Copy link
Owner

pwnall commented Aug 9, 2015

@gdi2290 Do you mean file:// support?

@PatrickJS
Copy link

yeah, Cordova uses file:// but I'm not sure if the PR relates to it

@pwnall
Copy link
Owner

pwnall commented Aug 9, 2015

The PR doesn't do much, but the bug is meaningful.

Can you please make sure that's necessary?

file:// is hard to test has non-trivial security implications, so I'd like to make sure the implementation effort is worth it.

@PatrickJS
Copy link

we can worry about file:// when we get there (after I test Ionic2) at the moment don't worry about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants