Rename update_signcolumn to update_signs

pwntester · Jun 8, 2024 · 6963068 · 6963068
1 parent 9511b1b
commit 6963068
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/lua/octo/autocmds.lua b/lua/octo/autocmds.lua
@@ -1,3 +1,4 @@
+local vim = vim
 local create = vim.api.nvim_create_augroup
 local define = vim.api.nvim_create_autocmd
 
@@ -65,7 +66,7 @@ function M.setup()
   })
 end
 
-function M.update_signcolumn(bufnr)
+function M.update_signs(bufnr)
   define({ "TextChanged", "TextChangedI" }, {
     group = "octobuffer_autocmds",
     buffer = bufnr,

diff --git a/lua/octo/model/octo-buffer.lua b/lua/octo/model/octo-buffer.lua
@@ -238,25 +238,23 @@ end
 function OctoBuffer:configure()
   -- configure buffer
   vim.api.nvim_buf_call(self.bufnr, function()
-    local use_signcolumn = config.values.ui.use_signcolumn
-    local use_statuscolumn = config.values.ui.use_statuscolumn
-    local use_foldtext = config.values.ui.use_foldtext
     vim.cmd [[setlocal filetype=octo]]
     vim.cmd [[setlocal buftype=acwrite]]
     vim.cmd [[setlocal omnifunc=v:lua.octo_omnifunc]]
     vim.cmd [[setlocal conceallevel=2]]
     vim.cmd [[setlocal nonumber norelativenumber nocursorline wrap]]
 
-    if use_statuscolumn then
+    if config.values.ui.use_signcolumn then
+      vim.cmd [[setlocal signcolumn=yes]]
+      autocmds.update_signs(self.bufnr)
+    end
+    if config.values.ui.use_statuscolumn then
       vim.opt_local.statuscolumn = [[%!v:lua.require'octo.ui.statuscolumn'.statuscolumn()]]
+      autocmds.update_signs(self.bufnr)
     end
-    if use_foldtext then
+    if config.values.ui.use_foldtext then
       vim.opt_local.foldtext = [[v:lua.require'octo.folds'.foldtext()]]
     end
-    if use_signcolumn then
-      vim.cmd [[setlocal signcolumn=yes]]
-      autocmds.update_signcolumn(self.bufnr)
-    end
   end)
 
   self:apply_mappings()